This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Fix reactivated users not being added to directory#10762
Merged
DMRobertson merged 6 commits intodmr/user-directory-nickname-leaksfrom Sep 8, 2021
Merged
Fix reactivated users not being added to directory#10762DMRobertson merged 6 commits intodmr/user-directory-nickname-leaksfrom
DMRobertson merged 6 commits intodmr/user-directory-nickname-leaksfrom
Conversation
dklimpel
reviewed
Sep 5, 2021
Co-authored-by: Dirk Klimpel <5740567+dklimpel@users.noreply.github.com>
DMRobertson
pushed a commit
that referenced
this pull request
Sep 6, 2021
Handled in separate PR #10762
clokep
reviewed
Sep 7, 2021
Member
clokep
left a comment
clokep
left a comment
There was a problem hiding this comment.
Looks good overall! Thanks for adding tests!
Member
|
For cross-referencing, I'm assuming this was split out of #10761? |
Contributor
Author
That's right, I spotted it as part of that work. |
DMRobertson
pushed a commit
that referenced
this pull request
Sep 8, 2021
I meant to merge this to develop, but screwed my git-fu. This reverts commit 401c1e8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulled this out of larger WIP changes because it's small and relatively isolated from the other changes.
The problem here is that
handle_local_profile_changechecks the DB to ensure the user isn't deactivated before upserting a directory entry.. So we need to reactivate them before calling this function, otherwise it'll do nothing.